Skip to content

Fix plugin test failures: API mismatches and registration timeouts#385

Merged
hotlong merged 3 commits intocopilot/update-action-run-referencesfrom
copilot/fix-all-and-test
Feb 5, 2026
Merged

Fix plugin test failures: API mismatches and registration timeouts#385
hotlong merged 3 commits intocopilot/update-action-run-referencesfrom
copilot/fix-all-and-test

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Feb 5, 2026

CI failing on plugin-list tests due to component API drift and async import timeouts across multiple plugin packages.

Changes

Test Assertions Updated

  • Search input: /search/i/find/i (matches current placeholder)
  • ViewSwitcher: getByRole('radio')getByLabelText() with aria-pressed (no longer uses radio role)
  • View type: 'list''kanban' (list view doesn't exist; valid types: grid, kanban, gallery, calendar, timeline, gantt, map)

Registration Test Timeouts

  • Added 15s timeout to beforeAll hooks in plugin-kanban, plugin-aggrid, plugin-markdown
  • Matches existing pattern in plugin-detail, plugin-charts (30s), plugin-editor (30s)

Export Consistency

  • Added chartComponents export to plugin-charts for manual integration pattern
// plugin-charts/src/index.tsx
export const chartComponents = {
  'bar-chart': ChartBarRenderer,
  'chart': ChartRenderer,
};

Test Results

  • plugin-list: 14 tests passing
  • plugin-kanban: 26 tests passing
  • plugin-aggrid, plugin-markdown, plugin-charts, plugin-editor, runner: all passing
Original prompt

引用: https://github.com/objectstack-ai/objectui/actions/runs/21680581795/job/62552407296#step:8:1

fix all and test


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

@vercel
Copy link
Copy Markdown

vercel bot commented Feb 5, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
objectui Ready Ready Preview, Comment Feb 5, 2026 0:51am
objectui-console Ready Ready Preview, Comment Feb 5, 2026 0:51am
objectui-storybook Ready Ready Preview, Comment Feb 5, 2026 0:51am

Request Review

Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix errors and run all tests Fix plugin test failures: API mismatches and registration timeouts Feb 5, 2026
Copilot AI requested a review from hotlong February 5, 2026 00:54
@hotlong hotlong marked this pull request as ready for review February 5, 2026 01:20
Copilot AI review requested due to automatic review settings February 5, 2026 01:20
@hotlong hotlong merged commit 34ada07 into copilot/update-action-run-references Feb 5, 2026
8 of 9 checks passed
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes CI test failures in multiple plugin packages by updating test assertions to match the current API implementation and adding timeout configurations for async imports.

Changes:

  • Updated test assertions in plugin-list to match current implementation (search placeholder, ViewSwitcher API, and view types)
  • Added 15-second timeouts to beforeAll hooks in plugin-markdown, plugin-kanban, and plugin-aggrid tests for async imports
  • Added chartComponents export to plugin-charts following the Standard Export Protocol pattern

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
packages/plugin-list/src/tests/ListView.test.tsx Fixed search placeholder regex from /search/i to /find/i to match actual "Find..." placeholder; updated ViewSwitcher assertions to use getByLabelText instead of getByRole('radio'); changed test view type from 'list' to 'kanban' (valid type); added required kanban options
packages/plugin-list/src/tests/ListViewPersistence.test.tsx Updated persistence tests to use 'kanban' instead of invalid 'list' view type; added required options.kanban.groupField configuration for kanban view availability
packages/plugin-markdown/src/index.test.ts Added 15-second timeout to beforeAll hook for async import, consistent with plugin-detail
packages/plugin-kanban/src/index.test.ts Added 15-second timeout to beforeAll hook for async import, consistent with plugin-detail
packages/plugin-aggrid/src/index.test.ts Added 15-second timeout to beforeAll hook for async import, consistent with plugin-detail
packages/plugin-charts/src/index.tsx Added chartComponents export following the Standard Export Protocol pattern established in other plugins (aggrid, editor, kanban, markdown, dashboard)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants